Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh tooling page #12

Merged
merged 3 commits into from May 6, 2019
Merged

Refresh tooling page #12

merged 3 commits into from May 6, 2019

Conversation

carolynvs
Copy link
Collaborator

@carolynvs carolynvs commented May 2, 2019

  • Update description of duffle
  • Update description for porter.
  • Add entry for docker apps.

Preview available at https://deploy-preview-12--cnabio.netlify.com/community-projects/#tools

cc @silvin-lubecki in case he has a different logo for docker apps than the whale.

* Explain that duffle is best for running, not authoring bundles.
* Update description for porter
* Add entry for docker apps
@@ -14,14 +14,26 @@ use in your own project.

## Duffle
<a href="https://duffle.sh" alt="duffle"><img align="right" src="/img/duffle.svg" width="64px" /></a>
Duffle is a command line tool that allows you to install and manage CNAB bundles.
Duffle is the reference implementation of the CNAB specification. It is best for
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not like this change. You changed the text from something that was accurate and reasonable to something that implies a deficiency in Duffle, and in an area that the original text did not even call out.

Copy link
Member

@technosophos technosophos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels like you are throwing shade on Duffle to make Porter more appealing, and I disagree with taking that approach.

@carolynvs
Copy link
Collaborator Author

It wasn't my intent to disparage duffle and I apologize for that.

I'm going to hold off on updating this PR to see if we decide on an updated description for duffle in cnabio/duffle#739 and I'll use the same text in this PR.

you use reuse existing scripts and tools such as Helm, Terraform, Kubernetes, and Azure.

## Docker Apps
<a href="https://github.com/docker/app" alt="docker"><img align="right" src="/img/docker.png" width="97px" /></a>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use the last logo ? I can send it to you. Does SVG fit?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! Yes please send it to me and I'll use it

Porter provides a declarative authoring experience with composable bundles that lets
you use reuse existing scripts and tools such as Helm, Terraform, Kubernetes, and Azure.

## Docker Apps

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docker App is better 😉

@carolynvs
Copy link
Collaborator Author

Ok! The duffle description has been updated to match the other PR and the Docker Apps entry now follows the branding guidelines.

Copy link
Member

@technosophos technosophos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my POV, this is ready to merge. I don't feel like I need to re-review for the new SVG, so I am marking this as LGTM.

Copy link

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you!

@carolynvs carolynvs merged commit 6abb6e3 into cnabio:master May 6, 2019
@carolynvs carolynvs deleted the tooling branch May 6, 2019 20:02
@ghost ghost removed the review label May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants