New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default path validation on push #66
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/test |
1 similar comment
/test |
jdolitsky
reviewed
Apr 12, 2019
jdolitsky
approved these changes
Apr 12, 2019
Tests failing w
|
/test |
fixed |
jdolitsky
approved these changes
Apr 12, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To generate oras packages / images with good qualities, i.e. secure and cross-platform,
oras
now checks the image title / path name to push with the following rules:foo/bar
OKfoo/../bar
NOT OKbar
OK./bar
NOT OKfoo/bar
OKfoo\bar
NOT OK/foo/bar
NOT OKC:\foo\bar
NOT OKC:/foo/bar
NOT OK..
NOT OK../bar
NOT OKfoo/../../bar
NOT OKNote: All checks are at the
oras
package level, not the CLI level.If the user is using
oras
CLI, the rule (1) is always true.With #65, the rules (2)-(4) are always true.
Therefore, this validation is basically equvilant to the rule (5).
To disable path validation, you can either
oras.WithNameValidation(nil)
tooras.Push()
.oras
with--disable-path-validation
.Resolves #57