Wrap steps in the containing action #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
install: - exec: ...
ghost
assigned When sending steps to a mixin, provide context by wrapping them in the containing action (e.g. install, uninstall) so that the mixins can validate them against their schemas without having to maintain a separate set of schema per action. This also will set us up for when `mixin build` will send a list of steps per action to validate.
carolynvs
force-pushed
the
wrap-step-in-action
branch
from
d1f6359
to
6a2e795
Compare
jeremyrickard
approved these changes
Mar 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When sending steps to a mixin, provide context by wrapping them in the containing action (e.g. install, uninstall) so that the mixins can validate them against their schemas without having to maintain a
separate set of schema per action. This also will set us up for when
mixin buildwill send a list of steps per action to validate.This should have been in #212 but ... wasn't. 馃槉 This also fixes the integration tests on master.