Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nav Styling: Issue #5 #6

Merged
merged 2 commits into from Mar 11, 2022
Merged

Conversation

staswerno
Copy link
Contributor

I tried my best to avoid the links breaking onto 3 lines, and the language selection breaking up, by having two versions of the language selection for varying breakpoints.

Here is large/xl:

Screenshot 2022-03-10 at 17 39 01

Here is medium:

Screenshot 2022-03-10 at 17 40 03

However, the problems remain at some specific viewport sizes:

Screenshot 2022-03-10 at 17 40 15

I also built the 'About' section in line with the rest of the navbar for consistency and better user experience.

Design file suggestion:

Screenshot 2022-03-10 at 17 52 20

My version:

Screenshot 2022-03-10 at 17 52 27

Hope that helps :)

@vercel
Copy link

vercel bot commented Mar 10, 2022

@staswerno is attempting to deploy a commit to the Europratsya Team on Vercel.

A member of the Team first needs to authorize it.

@staswerno
Copy link
Contributor Author

Also, I wasn't able to make use of the full Tailwind color palette ('neutral' and 'sky' didn't work, for example). So I got as close as I could. My guess is it's a version issue.

@thestuntcoder
Copy link
Owner

This looks really nice! Thank you so much for your effort Staś!

No worries about the colors, default ones are as good as gold at this point. Design is more of a guideline as our goal is to help people as soon as possible.

@staswerno
Copy link
Contributor Author

Great! Glad to help. Is there anything I need to do to get it merged?

@thestuntcoder
Copy link
Owner

I was 100% certain I managed the merge last night. Let me check what happened.

@thestuntcoder thestuntcoder reopened this Mar 11, 2022
@thestuntcoder thestuntcoder merged commit 4d26ad4 into thestuntcoder:master Mar 11, 2022
@thestuntcoder
Copy link
Owner

Apparently, I didn't. It's now merged and deployed! 💪

Thank you so much for your help Staś!

@staswerno
Copy link
Contributor Author

staswerno commented Mar 11, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants