Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UnmarshalBinary is passed a copy of the given type, not the actual value #73

Closed
dekarrin opened this issue Dec 1, 2023 · 0 comments
Closed

UnmarshalBinary is passed a copy of the given type, not the actual value #73

dekarrin opened this issue Dec 1, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@dekarrin
Copy link
Owner

dekarrin commented Dec 1, 2023

This could be a problem when relying on pre-set members of a passed-in struct to change behavior within UnmarshalBinary. Therefore, this should be addressed. This is likely also an issue with UnmarshalText.

It's currently in branch ghi062-testBinary; look there for fix
@dekarrin dekarrin added the bug Something isn't working label Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dekarrin