Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow prometheus annotations to also configure spring boot management endpoints. #116

Closed
iocanel opened this issue Feb 8, 2019 · 1 comment
Labels
wontfix This will not be worked on

Comments

@iocanel
Copy link
Member

iocanel commented Feb 8, 2019

Currently, in order to use prometheus with spring boot, the user has to manually set:

management.endpoints.enabled-by-default=true
management.endpoints.web.exposure.include=health,info,metrics,prometheus

IMHO, addding @EnableServiceMonitor on top the main class is good enough to express the intention to expose the prometheus endpoint. And thus, the manual configuration should be made optional.

So, what ways do we have in order to pass this configuration to the application?

  1. Environment variables.
  2. Use a configmap with override properties and mount it to the application pod.
  3. Have the apt processor modify the actual application.properties (or yaml).

While option 3 seems to be the simplest, I want to keep the project as decoupled as possible from apt.

@iocanel iocanel added the wontfix This will not be worked on label Jul 15, 2019
@iocanel
Copy link
Member Author

iocanel commented Jul 15, 2019

I am closing this as won't fix as its pretty hacky.

@iocanel iocanel closed this as completed Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant