Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is CompositeApplication the most appropriate wording to be used ? #9

Closed
cmoulliard opened this issue Nov 21, 2018 · 1 comment
Closed

Is CompositeApplication the most appropriate wording to be used ? #9

cmoulliard opened this issue Nov 21, 2018 · 1 comment
Assignees
@aureamunoz
Labels
discussion

Comments

@cmoulliard
Copy link
Collaborator

Is @CompositeApplication the most appropriate wording to be used ? To be honest, I'm not sure.
We can keep it for the moment but the information that it includes is next used by the controller/operator deployed on openshift to generate the following resources which are mandatory for every microservices deployment : DeploymentConfig, Service, Route (optional)

A better name should be @ComponentAnnotation or even better @MicroserviceAnnotation

WDYT @iocanel ?
@iocanel
Copy link
Member

iocanel commented Jul 15, 2019

Renamed to ComponentApplication by @aureamunoz.

@iocanel iocanel closed this as completed Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aureamunoz aureamunoz

Labels
discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@iocanel @cmoulliard @aureamunoz