add range check for seeking, add seekToLive and seekToStart #20
Conversation
|
Don't merge yet. Still has minor problems. |
|
Working for me now pretty stable. Was a lot more complicated than expected. You better take a look at the final code. From my side this is free to merge. |
| player?.seekToTime(CMTimeMake(Int64(time), 1)) | ||
| let time = CMTime(seconds: time, preferredTimescale: 1000000000) | ||
| let seekableRange = player?.currentItem?.seekableTimeRanges.last?.CMTimeRangeValue | ||
| let seekableStart = seekableRange!.start |
There was a problem hiding this comment.
Can we avoid to force unwrap value here?
There was a problem hiding this comment.
ok will fix that.
|
Thanks for your PR, really appreciate it. I left some detailed feedback inline. |
… no seeking is possible
…ke them both public functions
| bufferTime = max(bufferTime, marginBuffer) | ||
| let seekableRange = player?.currentItem?.seekableTimeRanges.last?.CMTimeRangeValue | ||
| let latestPoint = max(seekableRange!.start, seekableRange!.end - bufferTime) | ||
| let earliesPoint = min(seekableRange!.end, seekableRange!.start + marginBuffer) |
There was a problem hiding this comment.
Can you do the same here for forced unwrap? User can call seekToSeekableXXX and get an unexpected crash there.
There was a problem hiding this comment.
Oh you are right. Will change that.
|
Can I ask for one last edit and then I'm ready to merge? 🎉 |
|
You can have as many edits as you like. I appreciate your feedback! |
|
Fixed that issue now. Any other problems you see? |
add range check for seeking, add seekToLive and seekToStart
|
There are still some changes I would like to see, I'm making them right now :) |
|
Updated a bit the implementation. It's on develop if you want to check them out. Let me know what you think. |
|
I will take a look at it! |
|
Works great. Are you going to release this as a new version before adding caching? |
|
Yup, I'll release it later today. |
|
Great! Thanks a lot 😃 |
|
Available in master. Tagged 0.4.0! |
Currently seeking on a livestream crashes playback (nothing to hear anymore, no real code crash) if you seek to a time out of the seekable range. Therefore I added a range check to the
seekmethod call.I also added seekToLive() and seekToStart() as helpers. They are used by the default seek method if the time to seek to is out of range.
Currently seekToLive() seeks to the latest seekable posistion in the data stream minus 5 seconds of buffer time. The 5 seconds are quite randomly picked and should be changed to a the value of the buffer configuration which might be added in a future release.