New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logger instance #3
Comments
Hi Yichi, thank you for your interest!
Thanks again 😃 /cc @yichizhang |
Cool! Yes it makes more sense to me now. Thanks. |
@yichizhang Actually you're right 😄 I was used to use it without carthage/cocoapods and I didn't realize the pain of all those I just release the Thanks and sorry about that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi Damien, the library is great, thanks.
I have one suggestion for the last line in
Logger.swift
:public let Log = Logger(formatter: .Default, theme: .Default)
First thing is, the name of an instance should not be capitalized? Would
public let log =
be better?Also, what do you think about leaving the responsibility of creating a Logger instance to the user, by deleting that line?
The text was updated successfully, but these errors were encountered: