Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Swift 3 and recommended project settings #4

Closed
wants to merge 2 commits into from
Closed

Update to Swift 3 and recommended project settings #4

wants to merge 2 commits into from

Conversation

kiliankoe
Copy link
Contributor

Just tried out my project using Log with Swift 3 in the Xcode 8 Beta. Looks like there's currently no Swift 3 compatible branch here. It'd be great if you could merge this into a currently non existent branch on your repo or make the changes yourself if you want and close this PR.

Thanks 馃槉

@delba
Copy link
Owner

delba commented Jun 16, 2016

That's awesome! I was just talking with someone who's porting another of my project in swift-3.0 hartbit/Permission@5f7f606 ahaha

You guys are awesome! I'm gonna create a swift-3.0 branch and merge it tomorrow!

Thank you so much!

@kiliankoe
Copy link
Contributor Author

That's awesome! You're not at WWDC by any chance, are you? 馃槃

@delba
Copy link
Owner

delba commented Jun 16, 2016

Nope 馃槖

馃槂

@kiliankoe
Copy link
Contributor Author

That's a shame. Had the slight hope of meeting you here after you mentioned you were "talking with someone" 馃槣

@delba
Copy link
Owner

delba commented Jun 20, 2016

Hey @kiliankoe ,

Sorry for the late response, I had a busy weekend.

I just pushed the swift-3.0 branch. I'm closing this PR. Could you please create a new one to merge on the new branch?

Thanks!

@delba delba closed this Jun 20, 2016
@kiliankoe
Copy link
Contributor Author

Umm, I have to admit I'm kinda stumped here... Is there a reason for starting the new branch completely fresh? I thought I knew my way around git, but I can't manage to send a mergeable PR to the new branch without basically just copying the entire directory over 馃槙
If you want you can also go ahead and just run the Xcode 8 migrator yourself if that makes things easier. That's basically everything I did 馃槉

@delba
Copy link
Owner

delba commented Jun 22, 2016

My bad! I fixed it, it should be good now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants