Issue in following the README for handling incoming requests in the AppDelegate

[fabiomassimo]

From the docs:

Step 2: Handle the incoming requests

Handle the incoming requests in your AppDelegate:

func application(app: UIApplication, openURL url: NSURL, options: [String : AnyObject]) -> Bool {
    github.handleURL(url, options: options)

    return true
}

Unfortunately, while I was following the README, I found out that that the delegate method signature is slightly different:

func application(application: UIApplication, openURL url: NSURL, sourceApplication: String?, annotation: AnyObject) -> Bool

This causes an inconsistency with the designated method to handle an URL from the Provider.

    /**
     Handles the incoming URL.

     - parameter URL:     The incoming URL to handle.
     - parameter options: A dictionary of launch options.
     */
    public func handleURL(URL: NSURL, options: [String : AnyObject])

I think it should be rewritten in something like:

public func handleURL(URL: NSURL, sourceApplication: String?) 

Such that the Step 2 from the README would look like:

func application(application: UIApplication, openURL url: NSURL, sourceApplication: String?, annotation: AnyObject) -> Bool {
    github.handleURL(url, sourceApplication: sourceApplication)

    return true
}

[delba]

func application(app: UIApplication, openURL url: NSURL, options: [String : AnyObject]) is available in iOS 9 and the other ones are deprecated.

Since I plan to drop the support for iOS8 when iOS10 is released, I think it's better to leave it like that.

[delba]

@fabiomassimo I changed my mind, I'm gonna support both 😄

I'm gonna do it unless you want to?

[fabiomassimo]

On it :)

[delba]

Ahaha me too

I'm almost done :)

[fabiomassimo]

Hahahaha ok I'll step back.

[delba]

It took me way longer than expected but here it is: f2b743a

[delba]

Also I encounter a problem when testing on iOS 8.

UIApplicationDidBecomeActiveNotification is called before application:openURL:sourceApplication:annotation: and thus the completion block is called twice. First with Failure(.Cancel) and next with Success(token).

It's maybe because I tested it in the simulator (?)