Keychain token store #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
THIS.IS.MARVELOUS Seriously I'm going out but I'll check it in details tomorrow. Thank you so much! |
|
Oh, I didn't noticed, that Token.dictionary has a public interface. I would be better to fetch this instead of constructing a new one within KeychainStore.setToken .. |
|
I merge the PR in the Thanks @johannwilfling 👍 👍 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested, keychain support should not be based on third-party libraries, but uses a small wrapper found at https://gist.github.com/jackreichert/414623731241c95f0e20
Hint:
func setToken() should return a Bool value, but has to be changed at protocol level (TokenStore).