Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add convenience methods for "accounts-password" methods #14

Open
ocram opened this issue May 14, 2015 · 2 comments
Open

Add convenience methods for "accounts-password" methods #14

ocram opened this issue May 14, 2015 · 2 comments

Comments

@ocram
Copy link
Contributor

ocram commented May 14, 2015

Right now, the Meteor class already has convenience methods for the following two methods from the accounts-password package:

  • createUser
  • login

We should add further methods that wrap the following method calls:

  • logout
  • verifyEmail
  • changePassword
  • forgotPassword
  • resetPassword
@FranciscoVictor
Copy link

Hi there!

I had to code the changePassword convenience method on the application that I'm developing and it is declared as follows:

public void changePassword(final String currentPassword, final String newPassword, final ResultListener listener) {
        MeteorSingleton.getInstance().call("changePassword", new Object[]{currentPassword, newPassword}, listener);
}

Calling it this way:

changePassword(currentPassword, newPassword, new ResultListener() {
        @Override
        public void onSuccess(String result) {
        //TODO: Success logic goes here.
        System.out.println("Password changed: " + result);
        }

        @Override
        public void onError(String error, String reason, String details) {
        //TODO: Error logic goes here.
        System.out.println("Could not change password: " + error
                                        + " / " + reason + " / " + details);
        }
);

I make the necessary checks on the passwords before handling them to the method call.

I'm not a very experienced developer, but I thought that it would be nice to contribute to your project in some way.

Also, I think I will develop the forgotPassword and resetPassword methods in the future, since I'll need them too.

@ocram
Copy link
Contributor Author

ocram commented Oct 7, 2015

@FranciscoVictor Thank you, that was definitely helpful!

If you look at the login methods, you can see that they work in a similar way. Basically, one has to figure out which method name to call and then what parameters to pass.

Due to the lack of good documentation by Meteor for its DDP protocol, it's mainly trying what works.

So you tried your method above and it works correctly, right? So we can easily add it to the library soon :)

Feel free to share your implementations for the other methods as well when you do them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants