Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support all locale specifications? #6

Open
felixwiemuth opened this issue Sep 20, 2017 · 1 comment
Open

Support all locale specifications? #6

felixwiemuth opened this issue Sep 20, 2017 · 1 comment

Comments

@felixwiemuth
Copy link

The parsing in /Source/library/src/main/java/im/delight/android/languages/Language.java seems mandatory but it does not support the third optional argument in the Locale(String language, String country, String variant) constructor and does thus not support all locales (those with variants in the code) or am I wrong?

@ocram
Copy link
Contributor

ocram commented Sep 21, 2017

Correct. Thanks!

This library currently only supports the language and the country, not the additional variant.

Though the list of possible language codes is fixed as well, so unless you fork this library, you won't have any languages codes that can't be parsed correctly. And if you do, you can patch the parsing as well, of course.

So there's only a problem here if some languages are missing which you need.

Any pull requests welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants