Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Method errors without a "reason" are not parsed correctly #32

Closed
michaelstephendavies opened this issue Oct 14, 2015 · 1 comment
Closed

Method errors without a "reason" are not parsed correctly #32

michaelstephendavies opened this issue Oct 14, 2015 · 1 comment
Labels
bug

Comments

@michaelstephendavies
Copy link

At Protocol.java:84 you check for Protocol.Field.REASON where I assume you meant Protocol.Field.ERROR. This means that if the error has an error field but not a reason field, the error is incorrectly null.
@ocram ocram added the bug label Oct 15, 2015
@ocram
Copy link
Contributor

ocram commented Oct 15, 2015

Thank you so much! You're absolutely right, of course :)

Should be fixed with 3a3b153

@ocram ocram closed this as completed Oct 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michaelstephendavies @ocram