Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maven #34

Closed
kordianbruck opened this issue Nov 10, 2015 · 9 comments
Closed

Maven #34

kordianbruck opened this issue Nov 10, 2015 · 9 comments

Comments

@kordianbruck
Copy link

Would be awesome, if one could get the source code directly via maven.

Currently it is kinda messy to include the source code as a separate module in android studio.

@kordianbruck kordianbruck changed the title Mave Maven Nov 10, 2015
@ocram
Copy link
Contributor

ocram commented Nov 10, 2015

@kordianbruck
Copy link
Author

Well yes, a JAR works fine, but if you want to publish your app open source, other people should be able to just download the source code and all dependencies will also be then downloaded automatically. I am not sure if this works with Autobahn in this project, but it make the usage way easier.

Check out this blog article for a proper explanation:
http://inthecheesefactory.com/blog/how-to-upload-library-to-jcenter-maven-central-as-dependency/en

@ocram
Copy link
Contributor

ocram commented Nov 11, 2015

Thanks, I see your point.

I will look into this, but it may take some time. Sorry!

Leaving this issue open until it's done :)

@ocram ocram mentioned this issue Nov 18, 2015
@jitpack-io
Copy link

Hi

Would be very easy publish Android-DPP as a maven library on JitPack.io. All that's needed is a Gradle build file. Happy to submit a PR if you're interested.
https://jitpack.io/#delight-im/Android-DDP

@ocram
Copy link
Contributor

ocram commented Dec 15, 2015

@jitpack-io Yes, please feel free to submit a pull request! This will allow us to judge if using your service is indeed more convenient while still fulfilling the requirements. Maybe it will solve the Maven issue for us :)

@jitpack-io
Copy link

Ok great, submitted PR #45. To publish a new version simply add a GitHub release. That's it:)

@ocram
Copy link
Contributor

ocram commented Jan 27, 2016

Can someone please try if you can include this library as a Maven dependency in Gradle now?

  • Declare the Gradle repository in your root build.gradle

    allprojects {
       repositories {
           maven { url "https://jitpack.io" }
       }
    }
  • Declare the Gradle dependency in your app module's build.gradle

    dependencies {
       compile 'com.github.delight-im:Android-DDP:413cd62cb6'
    }

@kordianbruck
Copy link
Author

@mwaclawek Yes - works like a charm! Thanks!

@ocram
Copy link
Contributor

ocram commented Jan 28, 2016

The README has been updated with the Gradle dependency information:
https://github.com/delight-im/Android-DDP/blob/59e79b8e19c9ac74c7e428fa1bb4d50fc9b00b4a/README.md#installation

Thanks for testing, @kordianbruck, and thanks for providing this service, @jitpack-io!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants