/
2-open-closed.php
195 lines (163 loc) · 2.95 KB
/
2-open-closed.php
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
<?php
/**
* Violación del principio
*
* $patas = new CalculatePatas(
* ['cow','chicken','cow']
* );
* $patas->sum();
*
*/
class CalculatePatas {
protected $sum;
protected $animals;
public function __construct($animals = [])
{
$this->sum = 0;
$this->animals = $animals;
}
public function sum()
{
foreach($this->animals as $animal) {
if($animal == 'cow') {
$this->sum += 4;
}
if($animal == 'chicken') {
$this->sum += 2;
}
}
}
public function getSum()
{
return $this->sum;
}
}
/**
* Primer refactor
*
* $patas = new CalculatePatasRefactorOne(
* [
* new Cow(),
* new Chicken(),
* new Cow()
* ]
* );
* $patas->sum();
*
*/
/**
* Clases de referencia
*/
class Cow
{
protected $patas;
public function __construct()
{
$this->patas = 4;
}
public function patas()
{
return $this->patas;
}
}
class Chicken
{
protected $patas;
public function __construct()
{
$this->patas = 2;
}
public function patas()
{
return $this->patas;
}
}
class CalculatePatasRefactorOne
{
protected $sum;
protected $animals;
public function __construct($animals = [])
{
$this->sum = 0;
$this->animals = $animals;
}
public function sum()
{
$patas = [];
foreach ($this->animals as $animal) {
$patas[] = $animal->patas();
}
$this->sum = array_sum($patas);
}
public function getSum()
{
return $this->sum;
}
}
/**
* Segundo refactor
*
* $patas = new CalculatePatasRefactorTwo(
* [
* new CowAnimal(),
* new ChickenAnimal(),
* new CowAnimal()
* ]
* );
* $patas->sum();
*
*/
interface AnimalInterface
{
public function patas();
}
class CowAnimal implements AnimalInterface
{
protected $patas;
public function __construct()
{
$this->patas = 4;
}
public function patas()
{
return $this->patas;
}
}
class ChickenAnimal implements AnimalInterface
{
protected $patas;
public function __construct()
{
$this->patas = 2;
}
public function patas()
{
return $this->patas;
}
}
class CalculatePatasRefactorTwo
{
protected $sum;
protected $animals;
public function __construct($animals = [])
{
$this->sum = 0;
$this->animals = $animals;
}
public function sum()
{
$patas = [];
foreach ($this->animals as $animal) {
if($animal instanceof AnimalInterface){
$patas[] = $animal->patas();
continue;
}
throw new CalculatePatasInvalidAnimalException;
}
$this->sum = array_sum($patas);
}
public function getSum()
{
return $this->sum;
}
}