Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data.requires[{ inconsistent array}] #16

Closed
TheRayCannon opened this issue Apr 19, 2022 · 2 comments
Closed

data.requires[{ inconsistent array}] #16

TheRayCannon opened this issue Apr 19, 2022 · 2 comments

Comments

@TheRayCannon
Copy link

This is just looking at the "sorceries" request, but I wouldnt be shocked if it went further. So when looking at the array of "requires" it is too inconsistent to use as a source of sorting the overall fetch. we see that there are some which contain "intelligence" "faith" and "arcane" (ideal) while others will be missing some of the attributes or will have abbreviated the name (check out "Carian Slicer" requires [{"name": "Int", "amount": 14]) this is making it impossible to cater a list based on these nested arrays. Is there anyway to fix this across all fields (including weapons, incantations, ect?)

Thanks so much!

@deliton
Copy link
Owner

deliton commented Apr 23, 2022

Hey RayCannon! Thanks for pointing this out! We'll do a release next week and those things will hopefully get fixed.

@deliton
Copy link
Owner

deliton commented May 30, 2022

Hey! I haven't had the time to address all the bugs, but just released a patch that fixes most of those issues. Thanks for the issue ;)

@deliton deliton closed this as completed May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants