Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Allow lookup of _scaling_ values in GQL #9

Merged
merged 1 commit into from Apr 1, 2022
Merged

FIX: Allow lookup of _scaling_ values in GQL #9

merged 1 commit into from Apr 1, 2022

Conversation

julesferreira
Copy link
Contributor

A typo in a GQL field leads to an attempted lookup of a nonexistent JSON
key. Update the schema and corresponding documentation.

Loving the API! I noticed scaling tiers were returning null from the GQL endpoint- looks like a little typo:

Request

# extra L in `scalling`, as defined in GQL schema
curl 'https://eldenring.fanapis.com/api/graphql' -H 'Content-Type: application/json' --data-binary '{"query":"{getWeapon(id:\"17f69d12746l0i1ojbzxzgz6gfjsi\"){name scalesWith{name scalling}}}"}'

Response

{"data":{"getWeapon":{"name":"Longbow","scalesWith":[{"name":"Str","scalling":null},{"name":"Dex","scalling":null}]}}}

A typo in a GQL field leads to an attempted lookup of a nonexistent JSON
key. Update the schema and corresponding documentation.
@vercel
Copy link

vercel bot commented Mar 31, 2022

Someone is attempting to deploy a commit to a Personal Account owned by @deliton on Vercel.

@deliton first needs to authorize it.

@vercel
Copy link

vercel bot commented Mar 31, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

docs-eldenring-api – ./docs

🔍 Inspect: https://vercel.com/deliton/docs-eldenring-api/3E1fWF2v4dMNZ5Ju6mW2emMYcg1u
✅ Preview: https://docs-eldenring-api-git-fork-julesferreira-fix-sc-773c82-deliton.vercel.app

eldenring-api – ./api

🔍 Inspect: https://vercel.com/deliton/eldenring-api/EzZsdBXqfPkXNMkfVDY73vofvgG5
✅ Preview: https://eldenring-api-git-fork-julesferreira-fix-scaling-typo-deliton.vercel.app

@deliton
Copy link
Owner

deliton commented Apr 1, 2022

Nice catch! PR looks good. I'll do some quick testing with the preview version and then merge it. Thanks for the PR @julesferreira

@deliton
Copy link
Owner

deliton commented Apr 1, 2022

All seems to be working, thanks!

image

@deliton deliton merged commit 52ae346 into deliton:main Apr 1, 2022
@julesferreira julesferreira deleted the fix-scaling-typo branch April 1, 2022 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants