Skip to content
This repository has been archived by the owner on Dec 1, 2023. It is now read-only.

Does not always run #3

Open
moisesrodriguez opened this issue Feb 28, 2020 · 1 comment
Open

Does not always run #3

moisesrodriguez opened this issue Feb 28, 2020 · 1 comment

Comments

@moisesrodriguez
Copy link

I have this action set for pull request: open, reopened, edited

name: Attach to Trello
on:
  pull_request:
    types: [opened, reopened, edited]
jobs:
  attach-trello:
    runs-on: ubuntu-latest
    name: Find trello link and attach to card
    steps:
      - uses: delivered/attach-to-trello-card-action@master
        with:
          trello-key: ${{ secrets.TRELLO_KEY }}
          trello-token: ${{ secrets.TRELLO_TOKEN }}

However, I've had times that a pull request is opened and the action does not run. I have to edit it to have it run. Other times it runs but it fails as if it does not find a Trello link, but the link is there. Again what I do is edit it and then it runs successfully.

Any ideas why this might be happening?

@brianhenryhf
Copy link
Contributor

For the action not running: your config looks right. I've definitely seen a little bit of a delay some times before GH kicks off the action. I'd make sure to give it about 30 seconds before determining it isn't running. You can look at the Actions tab for your project using this (https://github.com/{YOUR_USER/ORG}/{YOUR_PROJECT}/actions) to see a list of runs (note you may have to refresh the page a few times to see recent actions, as the list doesn't seem to dynamically update).

For not finding a link: Just to clarify 'failing', this should ideally never truly 'fail' (as in a red 'x' on the Actions tab, accompanying error message when that entry is clicked). If it does, I'd love to hear more, as that sounds like a bug. If it doesn't find a link, it should still 'pass' (green checkmark on Actions tab), but it won't have any effect.

The current implementation does require the link (https://trello.com/c/XYXYXYXYX/845-mycard-is-here) be the starting text on the first line of the PR body (it can be preceded with spaces on that line). If editing (or closing and reopening) solves the problem though, you're probably ok there.

If you see any useful error text for a given run of the action (the below screenshot is passing, but you may see the red 'x' of failing/erroring?), please feel free to send it on, and I'll see if I can help.

image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants