You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Running the Hello World example using bogus facts the rulebook.getResults().isPresent() is true. Should the results be false? I was expecting a Null value.
Running the Hello World example using RuleBookBuilder using bogus facts the rulebook.getResults().isPresent() is false. Which is what I expected.
Love the RuleBook. Keep up the good work.
cheers,
Kent
The text was updated successfully, but these errors were encountered:
The RuleBookRunner that decorates a RuleBook and allows POJO Rule packages to be used as RuleBooks essentially creates an empty Result. The reason why it does that is so Results can be injected into POJO Rules. If there is no Result, then it can't very well be chained.
However, just because there is a good reason for why Results with POJO rules always exist, doesn't make that good expected behavior. So, I think you're right that this is something which should be corrected. I'll tag it as a bug and look at getting this corrected. Thanks for bringing it up!
The fix is in 0.8.1-SNAPSHOT now. I put some tests in there just to verify the scenarios where the Result of a RuleBookRunner should and should not be present. I'll probably push a patch release this weekend.
hellowordrule.txt
example4.1.txt
Hi Clayton,
Running the Hello World example using bogus facts the rulebook.getResults().isPresent() is true. Should the results be false? I was expecting a Null value.
Running the Hello World example using RuleBookBuilder using bogus facts the rulebook.getResults().isPresent() is false. Which is what I expected.
Love the RuleBook. Keep up the good work.
cheers,
Kent
The text was updated successfully, but these errors were encountered: