Skip to content

Commit

Permalink
feat: Remove purge flag from helm delete
Browse files Browse the repository at this point in the history
Not explicit that purge is what the users wants here. Not supported also
in helm3.
  • Loading branch information
colinjfw committed Sep 9, 2019
1 parent 5e2cd2f commit 3821f46
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions index.js
Original file line number Diff line number Diff line change
Expand Up @@ -206,15 +206,15 @@ async function run() {
// Remove the canary deployment before continuing.
if (removeCanary) {
core.debug(`removing canary ${appName}-canary`);
await exec.exec(helm, ["delete", `${appName}-canary`, "--purge"], {
await exec.exec(helm, ["delete", `${appName}-canary`], {
...opts,
ignoreReturnCode: true
});
}

// Actually execute the deployment here.
if (task === "remove") {
await exec.exec(helm, ["delete", release, "--purge"], {
await exec.exec(helm, ["delete", release], {
...opts,
ignoreReturnCode: true
});
Expand Down

0 comments on commit 3821f46

Please sign in to comment.