Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Too many login sessions in gopowerstore client causes unexpected session termination in UI #1006

Closed
donatwork opened this issue Oct 11, 2023 · 3 comments
Assignees
Labels
area/csi-powerstore Issue pertains to the CSI Driver for Dell EMC PowerStore type/bug Something isn't working. This is the default label associated with a bug issue.
Milestone

Comments

@donatwork
Copy link

donatwork commented Oct 11, 2023

Describe the solution you'd like
Many session requests from CSI driver and other modules making REST requests via the gopowerstore client. For example, in Observability (/api/rest/metrics/generate) around 1000 sessions per minute. it caused powerstore to cleanup the old sessions like existing GUI login session after exceed threshold 2000 sessions. Issue also seen when using in the powertore GUI, then after 2 min, the account was logout automatically due to this session cleaned.

The gopowerstore client should try to reuse the previous session and not create new sessions every time the REST API is used. This can help cut down on the number of active sessions on the array.

Describe alternatives you've considered
None. Client library handles connections.

Additional context
Problem may be alleviated if the gopowerstoer client reuses login sessions. Also saw that the CSI driver also makes hundreds of API calls (/api/rest/volume/, /api/rest/file_system, and /api/rest/nfs_export) when monitoring the volumes.

Problem impacts both the driver and modules.

@donatwork donatwork added needs-triage Issue requires triage. type/feature-request New feature request. This is the default label associated with a feature request issue. labels Oct 11, 2023
@csmbot
Copy link
Collaborator

csmbot commented Oct 11, 2023

@donatwork: Thank you for submitting this issue!

The issue is currently awaiting triage. Please make sure you have given us as much context as possible.

If the maintainers determine this is a relevant issue, they will remove the needs-triage label and respond appropriately.


We want your feedback! If you have any questions or suggestions regarding our contributing process/workflow, please reach out to us at container.storage.modules@dell.com.

@donatwork donatwork added the area/csi-powerstore Issue pertains to the CSI Driver for Dell EMC PowerStore label Oct 11, 2023
@gallacher gallacher added type/bug Something isn't working. This is the default label associated with a bug issue. and removed type/feature-request New feature request. This is the default label associated with a feature request issue. needs-triage Issue requires triage. labels Oct 12, 2023
@gallacher gallacher changed the title [FEATURE]: gopowerstore should reuse client sessions [BUG]: Too many API requests from CSM Observability for PowerStore Oct 12, 2023
@gallacher gallacher added this to the v1.9.0 milestone Oct 12, 2023
@donatwork
Copy link
Author

There are a large number of REST calls being made for volume, file_system, and nfs_export. As the number of volumes mounted increases and the number of clusters increase we will see may sessions.

@donatwork donatwork changed the title [BUG]: Too many API requests from CSM Observability for PowerStore [BUG]: Too many login sessions in gopowerstore client causes unexpected session termination in UI Oct 16, 2023
@gallacher
Copy link
Contributor

link: 18466

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/csi-powerstore Issue pertains to the CSI Driver for Dell EMC PowerStore type/bug Something isn't working. This is the default label associated with a bug issue.
Projects
None yet
Development

No branches or pull requests

4 participants