Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't pick custom icon in lawnchair #368

Closed
mintyleaf opened this issue Feb 8, 2022 · 19 comments
Closed

can't pick custom icon in lawnchair #368

mintyleaf opened this issue Feb 8, 2022 · 19 comments

Comments

@mintyleaf
Copy link

using last lawnchair 12 (#649 build, for example), with three dot menu -> experimental features -> per app icon customisation enabled, when I try to pick icon from Delta icon pack - there is no categories and icons at all, also when I press "open external picker" - Delta app just opens and I can't somehow send back to caller activity picked icon from there

I downloaded candy icons pack for testing - there I can pick icons
also I can pick system icons
so, I guess, there is some lack of up to date integration with icon picking thing in launcher

@SqrHornet
Copy link

Also can confirm. Doesn't happen with other icons pack (I checked viral icon pack)

@wokija
Copy link
Collaborator

wokija commented Feb 13, 2022

Unfortunately probably an incompatibility with CandyBar. We could reach out to Lawnchair devs to add support for it.

@Donnnno
Copy link
Contributor

Donnnno commented Feb 13, 2022

Good question! I don't know exactly...

Is the dashboard up to date with the candybar repo?

@maxtron95
Copy link
Collaborator

maxtron95 commented Feb 13, 2022

Also can confirm. Doesn't happen with other icons pack (I checked viral icon pack)

Might be off topic but, is this the latest Viral update that now uses a new (Blueprint) icon dashboard instead of the CandyBar one? I want to see if this is also affecting that dashboard as well or just only CandyBar.

@SqrHornet
Copy link

Also can confirm. Doesn't happen with other icons pack (I checked viral icon pack)

Might be off topic but, is this the latest Viral update that now uses a new (Blueprint) icon dashboard instead of the CandyBar one? I want to see if this is also affecting that dashboard as well or just only CandyBar.

Yes, that's the latest one using Blueprint. It works well.

@Donnnno
Copy link
Contributor

Donnnno commented Feb 13, 2022

Arcticons uses a modified candybar dashboard, and it still works :$

@SqrHornet
Copy link

SqrHornet commented Feb 13, 2022

@absurdusername Actually I do, I didn't know quickswitch might have had something to do with it in the first place. Still other icon packs manage to work 🤔

@leifniem
Copy link
Collaborator

Thanks for tagging me @absurdusername - if we're using the latest candybar (@wokija probably knows better than me) my only guesses would be a category name causing an error, our additional manual naming of the drawables or a broken drawable causing this.

@mintyleaf have you tried making a logcat yet? Since lawnchair is using debug builds by default iirc the output should be very detailed.

@wokija
Copy link
Collaborator

wokija commented Feb 14, 2022

We indeed use latest candybar version. I could try building an apk without the name attribute and see if that solves the issue. If so, we could just scrap the idea of using custom name for the sake of functionality.

Edit: working for me before trying what I stated above
Screenshot_20220214-004200

@Donnnno
Copy link
Contributor

Donnnno commented Feb 14, 2022

Can confirm, this works for me with delta too!

@leifniem
Copy link
Collaborator

@absurdusername have you tried it with the newest beta?

The logcat shows some resources missing, which I guess to be broken drawables, but since it works for other people it might be a specific lawnchair version that is prone to this bug.

@SqrHornet
Copy link

SqrHornet commented Feb 14, 2022

@absurdusername The icons do show after updating to newest beta. But there is another bug on my end and I'm not sure which app is to blame. Icon categories end with letter O. Also it's not possible to find any icon starting with P or any next letter via search bar. If you could verify if it happens in your case.
Screenshot_20220214-194229_Lawnchair

@mintyleaf
Copy link
Author

hey, sorry for misreading this)
how can I get latest beta?
I'm already beta tester in play store, but there is no update yet =\ (maybe I'm blind and I gotta go check this repo after commenting)
btw if logs still needed I easily can grab them tomorrow

@wokija
Copy link
Collaborator

wokija commented Feb 15, 2022

@SqrHornet you're right same on my end. Could you verify please? @wokija

Same on my device. That's strange

@mintyleaf
Copy link
Author

hey, sorry for misreading this) how can I get latest beta? I'm already beta tester in play store, but there is no update yet =\ (maybe I'm blind and I gotta go check this repo after commenting) btw if logs still needed I easily can grab them tomorrow

All good, you can get it here

it's working)

@leifniem
Copy link
Collaborator

leifniem commented Apr 4, 2022

I recently tested it with Lawnchair 12A5 and it seemed to work no problem at all, did anyone face any further issues?

@Donnnno
Copy link
Contributor

Donnnno commented Apr 4, 2022

Same. but found the error in the drawables:

image

<category title="P" />

@wokija
Copy link
Collaborator

wokija commented Apr 4, 2022

Same. but found the error in the drawables:

Not part of current release. I messed up the last conflicts correction 🙄

@leifniem
Copy link
Collaborator

This seems fixed in 12.1.0 Alpha 3. Can anyone confirm it is for them too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

6 participants