Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve mobile layout #6

Closed
r10s opened this issue Dec 18, 2022 · 1 comment · Fixed by #7
Closed

improve mobile layout #6

r10s opened this issue Dec 18, 2022 · 1 comment · Fixed by #7

Comments

@r10s
Copy link
Member

r10s commented Dec 18, 2022

nitpickings:

  • i think, the font could be a little larger
  • there should be always at least a little border around the textbox
  • less stars on mobile, maybe we should calculate the number of stars based on the width * height so that eg. 800 * 600 results in 200 stars

the desktop page, however, looks good. for such a summary, maybe desktio is the even more important part

@rosano
Copy link
Collaborator

rosano commented Dec 19, 2022

there should be always at least a little border around the textbox

I would say no more than 10px of padding, and it could also be only on the left/right.

@rosano rosano linked a pull request Dec 19, 2022 that will close this issue
@r10s r10s closed this as completed in #7 Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants