Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't build with Rust 1.46.0 #1873

Closed
link2xt opened this issue Aug 27, 2020 · 6 comments
Closed

Doesn't build with Rust 1.46.0 #1873

link2xt opened this issue Aug 27, 2020 · 6 comments
Labels
bug Something is not working

Comments

@link2xt
Copy link
Collaborator

link2xt commented Aug 27, 2020

Same bug that prevented nightly builds recently: #1835 (comment)

The bug has made it into stable release now.

error: reached the type-length limit while instantiating `std::future::from_generator::<[s...::SendFuture<'t10, ()>, ()}]>}]>`
   |
   = note: consider adding a `#![type_length_limit="2388377"]` attribute to your crate

error: aborting due to previous error

error: could not compile `deltachat`.
@link2xt link2xt added the bug Something is not working label Aug 27, 2020
@link2xt
Copy link
Collaborator Author

link2xt commented Aug 28, 2020

Rust issue: rust-lang/rust#64496

@link2xt
Copy link
Collaborator Author

link2xt commented Aug 28, 2020

With #![type_length_limit="2388377"] it builds.

cargo test fails with:

error: reached the type-length limit while instantiating `std::pin::Pin::<&mut std::future...::Future>::poll::{{closure}}#0]>`
    |
    = note: consider adding a `#![type_length_limit="2465609"]` attribute to your crate

error: aborting due to previous error

error: could not compile `deltachat`.

@link2xt
Copy link
Collaborator Author

link2xt commented Sep 15, 2020

New upstream issue to watch: rust-lang/rust#54540

It will probably be fixed with this PR: rust-lang/rust#72412

@link2xt
Copy link
Collaborator Author

link2xt commented Sep 19, 2020

#72412 is merged now

Another PR to watch which actually disables the check: rust-lang/rust#76772

@link2xt
Copy link
Collaborator Author

link2xt commented Sep 19, 2020

Nightly rustc 1.48.0-nightly (bbc677480 2020-09-18) already works.

@link2xt link2xt closed this as completed Sep 19, 2020
@r10s
Copy link
Member

r10s commented Sep 19, 2020

great! thanks for following that issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working
Projects
None yet
Development

No branches or pull requests

2 participants