New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
charater in display name affecting adjacent text #3479
Comments
thanks for filing the issue, i roughtly remember some things now :) i also think, removing only at the end does not help. we could make sure that an even number of so, the "name" field is probably not even the worst place where this character could do confusion or maybe harm. some options:
nice overview about this stuff, with xkcd comics, https://unicode-explorer.com/c/202E EDIT: according to https://stackoverflow.com/questions/41487035/handling-right-to-left-left-to-right-override-characters-in-user-input "real Arabic/Hebrew/etc keyboards can't type BiDi control characters" so they very likely come from malicious input, so removing them seems to be a viable option. would be interesting what other apps do on this issue ... |
copied text from a message in the picture:
the user has the display name set to
Evil Rabbit
(an special character
U+202E
is at the end that cause all subsequent text to be reverted)Maybe core should trim/strip display names and remove the characters, but I think not even removing from the end will help, and if removed from any position might actually affect some name in some language?
maybe there is some special character to limit/set boundaries of this character
The text was updated successfully, but these errors were encountered: