Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

synchronize broadcast list members #4953

Closed
r10s opened this issue Nov 7, 2023 · 2 comments
Closed

synchronize broadcast list members #4953

r10s opened this issue Nov 7, 2023 · 2 comments
Assignees
@iequidoo
Labels
enhancement New feature or request multi-device

Comments

@r10s
Copy link
Member

r10s commented Nov 7, 2023 •
edited

"broadcast lists" are lists from one sender to many receivers. the receivers do not get aware of each other directly.

currently, if you can create broadcast lists on one device, the other devices will see the broadcast list itself (no need to sync that part) - however, the receiver list is missing.

(you can try out broadcast lists when enabling the corresponding option in "Advanced")

as adding this feature is more straight-forward and does not open many disucssions, it should be targeted before #4893 or #4954

also, having this will allow to get broadcast-lists out of experimental
@r10s r10s added enhancement New feature or request multi-device labels Nov 7, 2023
This was referenced Nov 7, 2023
Closed
Closed
iequidoo added a commit that referenced this issue Nov 9, 2023
@iequidoo
sync chat contacts (#4953)
9832407 
TODO: tests
TODO: sync creating chats
iequidoo added a commit that referenced this issue Nov 9, 2023
@iequidoo
feat: Sync chat contacts across devices (#4953)
155ff59 
Sync chat contacts across devices for broadcast lists and groups. This needs the corresponding chat
to exist on other devices which is not the case for unpromoted groups, so it fails for them now but
it's only a warning and will work once creation of unpromoted groups is synchronised too.

TODO: tests
iequidoo added a commit that referenced this issue Nov 9, 2023
@iequidoo
feat: Sync creating broadcast lists across devices (#4953)
263bdd5
@iequidoo
Copy link
Collaborator

iequidoo commented Nov 10, 2023 •
edited

currently, if you can create broadcast lists on one device, the other devices will see the broadcast list itself (no need to sync that part)

It doesn't work for me, i enabled broadcast lists on my Desktop and Android, created a broadcast list on Desktop with one member (not me), sent a message, but don't see neither the list nor the message on Android. Also i wrote the same test in Rust and it doesn't work too. Will try to fix it later

UPD: Actually it isn't a bug, but just a missed feature. Done in #4975.

iequidoo added a commit that referenced this issue Nov 10, 2023
@iequidoo
feat: Sync chat contacts across devices (#4953)
a25e2dd 
Sync chat contacts across devices for broadcast lists and groups. This needs the corresponding chat
to exist on other devices which is not the case for unpromoted groups, so it fails for them now but
it's only a warning and will work once creation of unpromoted groups is synchronised too.
iequidoo added a commit that referenced this issue Nov 10, 2023
@iequidoo
feat: Sync creating broadcast lists across devices (#4953)
efc9a52
iequidoo added a commit that referenced this issue Nov 10, 2023
@iequidoo
test: Broadcast lists synchronisation (#4953)
1803bff
@iequidoo iequidoo mentioned this issue Nov 10, 2023
Merged
iequidoo added a commit that referenced this issue Nov 10, 2023
@iequidoo
feat: Sync chat contacts across devices (#4953)
59c274b 
Sync chat contacts across devices for broadcast lists and groups. This needs the corresponding chat
to exist on other devices which is not the case for unpromoted groups, so it fails for them now but
it's only a warning and will work once creation of unpromoted groups is synchronised too.
iequidoo added a commit that referenced this issue Nov 10, 2023
@iequidoo
feat: Sync creating broadcast lists across devices (#4953)
af6be37
iequidoo added a commit that referenced this issue Nov 10, 2023
@iequidoo
test: Broadcast lists synchronisation (#4953)
040766a
iequidoo added a commit that referenced this issue Nov 10, 2023
@iequidoo
feat: Sync creating broadcast lists across devices (#4953)
5ae9848
iequidoo added a commit that referenced this issue Nov 10, 2023
@iequidoo
test: Broadcast lists synchronisation (#4953)
48f900e
iequidoo added a commit that referenced this issue Nov 11, 2023
@iequidoo
feat: Sync Chat::name across devices (#4953)
9731d0a
iequidoo added a commit that referenced this issue Nov 11, 2023
@iequidoo
feat: Sync Chat::name across devices (#4953)
2938cf2
iequidoo added a commit that referenced this issue Nov 12, 2023
@iequidoo
feat: Multi-device broadcast lists (#4953)
26370e5
iequidoo added a commit that referenced this issue Nov 12, 2023
@iequidoo
feat: Multi-device broadcast lists (#4953)
bccbaa9
iequidoo added a commit that referenced this issue Nov 12, 2023
@iequidoo
feat: Sync creating broadcast lists across devices (#4953)
5721f9c
iequidoo added a commit that referenced this issue Nov 12, 2023
@iequidoo
test: Broadcast lists synchronisation (#4953)
9d23889
iequidoo added a commit that referenced this issue Nov 12, 2023
@iequidoo
feat: Sync Chat::name across devices (#4953)
89c4ca2
iequidoo added a commit that referenced this issue Nov 12, 2023
@iequidoo
feat: Multi-device broadcast lists (#4953)
f8c7467
iequidoo added a commit that referenced this issue Nov 13, 2023
@iequidoo
feat: Sync chat contacts across devices (#4953)
19c0cc3 
Sync chat contacts across devices for broadcast lists and groups. This needs the corresponding chat
to exist on other devices which is not the case for unpromoted groups, so it fails for them now but
it's only a warning and will work once creation of unpromoted groups is synchronised too.
iequidoo added a commit that referenced this issue Nov 13, 2023
@iequidoo
feat: Sync creating broadcast lists across devices (#4953)
245bc61
iequidoo added a commit that referenced this issue Nov 13, 2023
@iequidoo
test: Broadcast lists synchronisation (#4953)
7836ef7
iequidoo added a commit that referenced this issue Nov 13, 2023
@iequidoo
feat: Sync Chat::name across devices (#4953)
26047d4
iequidoo added a commit that referenced this issue Nov 13, 2023
@iequidoo
feat: Multi-device broadcast lists (#4953)
9abe6c0
iequidoo added a commit that referenced this issue Nov 13, 2023
@iequidoo
feat: Sync chat contacts across devices (#4953)
b849812 
Sync chat contacts across devices for broadcast lists and groups. This needs the corresponding chat
to exist on other devices which is not the case for unpromoted groups, so it fails for them now but
it's only a warning and will work once creation of unpromoted groups is synchronised too.
iequidoo added a commit that referenced this issue Nov 13, 2023
@iequidoo
feat: Sync creating broadcast lists across devices (#4953)
c1d45aa
iequidoo added a commit that referenced this issue Nov 13, 2023
@iequidoo
test: Broadcast lists synchronisation (#4953)
ce0f9b1
iequidoo added a commit that referenced this issue Nov 13, 2023
@iequidoo
feat: Sync Chat::name across devices (#4953)
956bb44
iequidoo added a commit that referenced this issue Nov 13, 2023
@iequidoo
feat: Multi-device broadcast lists (#4953)
15aec23
iequidoo added a commit that referenced this issue Nov 13, 2023
@iequidoo
feat: Sync chat contacts across devices (#4953)
4d1a9c2 
Sync chat contacts across devices for broadcast lists and groups. This needs the corresponding chat
to exist on other devices which is not the case for unpromoted groups, so it fails for them now but
it's only a warning and will work once creation of unpromoted groups is synchronised too.
iequidoo added a commit that referenced this issue Nov 13, 2023
@iequidoo
feat: Sync creating broadcast lists across devices (#4953)
7977c9a
iequidoo added a commit that referenced this issue Nov 13, 2023
@iequidoo
test: Broadcast lists synchronisation (#4953)
dc944d8
iequidoo added a commit that referenced this issue Nov 13, 2023
@iequidoo
feat: Sync Chat::name across devices (#4953)
74081d8
iequidoo added a commit that referenced this issue Nov 13, 2023
@iequidoo
feat: Multi-device broadcast lists (#4953)
ad5a5ad
@iequidoo
Copy link
Collaborator

Done in #4975

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iequidoo iequidoo

Labels
enhancement New feature or request multi-device
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@r10s @iequidoo