Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checks for node versions #2724

Closed
hpk42 opened this issue Apr 30, 2022 · 1 comment · Fixed by #2779
Closed

checks for node versions #2724

hpk42 opened this issue Apr 30, 2022 · 1 comment · Fixed by #2779
Assignees
Labels
bug Something isn't working

Comments

@hpk42
Copy link
Contributor

hpk42 commented Apr 30, 2022

Had some fun trying to build again, got a bunch of those errors, puzzling to me:

> deltachat-desktop@1.28.2 build:backend /home/hpk/p/delta/desktop
> tsc --build src/main

../node/dist/context.d.ts:9:10 - error TS2305: Module '"stream"' has no exported member 'EventEmitter'.

9 import { EventEmitter } from 'stream';

While the README says v14.0.0 or newer is required, i use v14.8.12. Turns out that v14.8.13 avoids the above error.
It seems that v16 (stable node) is actually working. The whole thing took me like an hour to figure out, and it has happened before that i stumbled into node version issues.
Could the "npm run build" (or npm install) be made to check that a known-to-work version (from some list) is used?

@hpk42 hpk42 added the bug Something isn't working label Apr 30, 2022
@Simon-Laux
Copy link
Member

Simon-Laux commented Apr 30, 2022

you need to use #2687, this is because deltachat-node master is already on node 16

or you just use the slightly older deltachat node version on tag 1.77.0 for now.

Could the "npm run build" (or npm install) be made to check that a known-to-work version (from some list) is used?

The readme of dc node says it uses node 16 now and the changelog of dc node also states that. also while doing npm i you should have gotten a warning that deltachat-node needs nodejs version 16 now, maybe that warning is broken?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants