Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overridden sender name property for outgoing/self messages not displayed #3843

Closed
adbenitez opened this issue May 21, 2024 · 0 comments · Fixed by #3856
Closed

overridden sender name property for outgoing/self messages not displayed #3843

adbenitez opened this issue May 21, 2024 · 0 comments · Fixed by #3856
Assignees
Labels
enhancement New feature or request

Comments

@adbenitez
Copy link
Member

adbenitez commented May 21, 2024

recently a bug in core was fixed (deltachat/deltachat-core-rust#5585) to include the overridden sender name property if present also for self/outgoing messages (the names with the ~ at the front) Delta Chat desktop should display the author/sender title in the top of the message bubble even for self messages if the overridden sender name property is present, this is already done by android on deltachat/deltachat-android#3056

It should be displayed when present, it doesn't matter if chat is a group or 1:1, based on the raw RPC API I think the property to check is MessageObject.overrideSenderName in the TypeScript bindings but not sure.

Delta Chat itself doesn't allow to set overridden sender name for a message from the clients, but it can happen that it is set by another email client of the user, for example by DeltaLab's recent communities support

for context, this is how it should look a message from self that has an overridden sender name set:
image

@adbenitez adbenitez added the enhancement New feature or request label May 21, 2024
@Simon-Laux Simon-Laux self-assigned this May 23, 2024
Simon-Laux added a commit that referenced this issue May 27, 2024
… yourself (#3856)

always show `overrideSenderName` if set on Messages

fix #3843
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants