Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor editgroup #970

Merged
merged 9 commits into from
Sep 10, 2019
Merged

Refactor editgroup #970

merged 9 commits into from
Sep 10, 2019

Conversation

nicodh
Copy link
Contributor

@nicodh nicodh commented Sep 8, 2019 •
edited by Jikstra
Loading

2 issues still:

  • Removing profile image results in a crash (probably core bug)
  • chat info in header needs update after modifyGroup
  • creating a group results in a blank dialog
  • the search bar on edit group is too high

@Jikstra
Copy link
Contributor

Jikstra commented Sep 8, 2019 •
edited
Loading

This already looks quite good, very nice!

Removing profile image results in a crash (probably core bug)

yup very likely: deltachat/deltachat-core-rust#454

@nicodh
Copy link
Contributor Author

nicodh commented Sep 10, 2019

Let's merge this now and fix the issues in next PR

@nicodh nicodh merged commit ae176db into rework_create_chat Sep 10, 2019
@nicodh nicodh deleted the refactor-editgroup branch September 10, 2019 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nicodh @Jikstra