Rework Forward Message Dialog, Chatlist and implement async lazy loading chatlist... #997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Jikstra
commented
Sep 19, 2019
•
Jikstra
commented
- Implement add contact over chat search (Fixes chatList.js:57 Uncaught TypeError: Cannot read property 'state' of null at EventEmitter.module.exports../src/renderer/stores/chatList.js.ipcRenderer.on (chatList.js:57) at EventEmitter.emit (events.js:187) #917)
- Implement lazy loading chatlist which only fetches what's in view
- Removes chatlist store (Fixes Search should only search non archived #396)
- Improves chatlist styling
- Use lazy loading chatlist in forward message dialog and tweak styling of that dialog
- Start moving from styled components to sass (thanks @Simon-Laux & @nicodh for pushing this, was a long trip for me to change my mind :D)
- Make settings dialog the same width as CreateChat/ForwardMessage dialog
- Refactored everything that was in my way
- Restyle & refactor MessageDetail dialog
- Fix Displayed wrong message in Import secret keys implementation #951, changes import secret keys file import title
- use a better and more fitting danger color
- the 'bad' option can now be chosen with the yesIsDanger prop, and
the danger option is always on the left side and in the red danger
color
- Make overlay opacity more prominent
- Add dialoger header border line to AddGroup Main dialog - Dont show initals
- Give create chat/group dialog a fixed height
forwarding message
Make ChatList a functional component
Fix get_draft
Jikstra
force-pushed
the
fix_refaword_forwad_message
branch
from
b543b7e
to
9cde0e8
Compare
Fix select chat
Fix context menu in chatlist
Jikstra
changed the title
Jikstra
changed the title
Jikstra
changed the title
Jikstra
changed the title
Jikstra
commented
Sep 25, 2019
| // Don't update if a draft changes | ||
| if (msgId === 0) return | ||
| this.onChatListChanged() | ||
| this.onChatListItemChanged(chatId) | ||
| this.onMessageUpdate(chatId, msgId, 'DC_EVENT_MSGS_CHANGED') |
There was a problem hiding this comment.
@nicodh the reason why we call onChatListChanged and onChatListItemChanged is because onChatListChanged triggers a refetch of the chatlist, which would result in a resorting of the displayed chatlists. The useLazyChatListItems hook only tries to fetch chats in view after chatListIds changed, but doesn't force refetch them (this is needed for search, where only the sort/which ids are shown changes but we don't want to refetch all chats). And this is where onChatListItemChanged comes into play, because if called with chatId=0, it force refetches all chats in view. It probably makes sense to split this into two events, onChatListItemChanged onChatListForceUpdateInView or something like this.
padding of no search result pseudo item in Member search
|
Compliance department says YOLO |
Simon-Laux
changed the base branch from
tweak_confirmation_dialog
to
master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.