Skip to content

Commit

Permalink
feat: move Configuration menu to Personal settings
Browse files Browse the repository at this point in the history
  • Loading branch information
deluan committed Apr 1, 2020
1 parent 6cddcd6 commit 9f00fb0
Show file tree
Hide file tree
Showing 9 changed files with 38 additions and 27 deletions.
2 changes: 1 addition & 1 deletion ui/src/App.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import artist from './artist'
import { Player, playQueueReducer } from './audioplayer'
import { albumViewReducer } from './album/albumState'
import customRoutes from './routes'
import themeReducer from './configuration/themeReducer'
import themeReducer from './personal/themeReducer'
import createAdminStore from './store/createAdminStore'

const i18nProvider = polyglotI18nProvider(
Expand Down
2 changes: 1 addition & 1 deletion ui/src/i18n/en.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export default deepmerge(englishMessages, {
menu: {
library: 'Library',
settings: 'Settings',
configuration: 'Configuration',
personal: 'Personal',
version: 'Version %{version}',
theme: 'Theme'
},
Expand Down
20 changes: 1 addition & 19 deletions ui/src/layout/AppBar.js
Original file line number Diff line number Diff line change
@@ -1,36 +1,19 @@
import React, { forwardRef } from 'react'
import {
AppBar as RAAppBar,
UserMenu,
MenuItemLink,
UserMenu,
useTranslate
} from 'react-admin'
import { makeStyles } from '@material-ui/core'
import InfoIcon from '@material-ui/icons/Info'
import TuneIcon from '@material-ui/icons/Tune'

const useStyles = makeStyles((theme) => ({
menuItem: {
color: theme.palette.text.secondary
}
}))

const ConfigurationMenu = forwardRef(({ onClick }, ref) => {
const translate = useTranslate()
const classes = useStyles()
return (
<MenuItemLink
ref={ref}
to="/configuration"
primaryText={translate('menu.configuration')}
leftIcon={<TuneIcon />}
onClick={onClick}
className={classes.menuItem}
sidebarIsOpen={true}
/>
)
})

const VersionMenu = forwardRef((props, ref) => {
const translate = useTranslate()
const classes = useStyles()
Expand All @@ -50,7 +33,6 @@ const VersionMenu = forwardRef((props, ref) => {

const CustomUserMenu = (props) => (
<UserMenu {...props}>
<ConfigurationMenu />
<VersionMenu />
</UserMenu>
)
Expand Down
2 changes: 2 additions & 0 deletions ui/src/layout/Menu.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import SettingsIcon from '@material-ui/icons/Settings'
import ViewListIcon from '@material-ui/icons/ViewList'
import SubMenu from './SubMenu'
import inflection from 'inflection'
import PersonalMenu from './PersonalMenu'

const translatedResourceName = (resource, translate) =>
translate(`resources.${resource.name}.name`, {
Expand Down Expand Up @@ -74,6 +75,7 @@ const Menu = ({ onMenuClick, dense, logout }) => {
dense={dense}
>
{resources.filter(subItems('settings')).map(renderMenuItemLink)}
<PersonalMenu dense={dense} sidebarIsOpen={open} />
</SubMenu>
{resources.filter(subItems(undefined)).map(renderMenuItemLink)}
{isXsmall && logout}
Expand Down
29 changes: 29 additions & 0 deletions ui/src/layout/PersonalMenu.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
import React, { forwardRef } from 'react'
import { MenuItemLink, useTranslate } from 'react-admin'
import { makeStyles } from '@material-ui/core'
import TuneIcon from '@material-ui/icons/Tune'

const useStyles = makeStyles((theme) => ({
menuItem: {
color: theme.palette.text.secondary
}
}))

const PersonalMenu = forwardRef(({ onClick, open, dense }, ref) => {
const translate = useTranslate()
const classes = useStyles()
return (
<MenuItemLink
ref={ref}
to="/personal"
primaryText={translate('menu.personal')}
leftIcon={<TuneIcon />}
onClick={onClick}
className={classes.menuItem}
sidebarIsOpen={open}
dense={dense}
/>
)
})

export default PersonalMenu
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ const useStyles = makeStyles({
select: { minWidth: 200 }
})

const Configuration = () => {
const Personal = () => {
const translate = useTranslate()
const classes = useStyles()
const theme = useSelector((state) => state.theme)
Expand Down Expand Up @@ -40,4 +40,4 @@ const Configuration = () => {
)
}

export default Configuration
export default Personal
File renamed without changes.
File renamed without changes.
6 changes: 2 additions & 4 deletions ui/src/routes.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
import React from 'react'
import { Route } from 'react-router-dom'
import Configuration from './configuration/Configuration'
import Personal from './personal/Personal'

export default [
<Route exact path="/configuration" render={() => <Configuration />} />
]
export default [<Route exact path="/personal" render={() => <Personal />} />]

0 comments on commit 9f00fb0

Please sign in to comment.