Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial support for Google Analytics #377

Merged
merged 1 commit into from
Jul 3, 2020
Merged

Add initial support for Google Analytics #377

merged 1 commit into from
Jul 3, 2020

Conversation

deluan
Copy link
Member

@deluan deluan commented Jul 3, 2020

No worries, this is not for me to collect any info from users, this is to allow admins to collect info about their own server usage, if they choose to do so

To enable it, just set GATrackingID to your tracking id. You can find it in Google Analytics' console (something like UA-XXXXXXX-XX)

@deluan deluan merged commit 1cc03fd into master Jul 3, 2020
@deluan deluan deleted the ga branch July 3, 2020 17:51
@Extarys
Copy link

Extarys commented Jul 7, 2020

If there is GA in there, could we implement a way to not load the google library if the user opt out?
Also, what kind of data you'd like to gather?

I'm sure you will share those information eventually, I just really don't like Google in general 😄 therefore I'm a bit concerned but I may opt-in at the beginning if it helps you then opt out later.

@deluan
Copy link
Member Author

deluan commented Jul 7, 2020

I'm not collecting any information from users, I don't even know how many copies of Navidrome are running out there.

The idea with this implementation is to allow admins to enable Google Analytics on their own installations. They can configure a GATrackingID with their own TrackingID, and this will be used by the React-GA library to send info to their own GA account, not mine!!

I added this because I'm setting up a demo instance of Navidrome, and would like some analytics for it.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants