Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hi Youtube embed doesn't work #15

Closed
hanymorcos opened this issue Aug 3, 2022 · 6 comments
Closed

Hi Youtube embed doesn't work #15

hanymorcos opened this issue Aug 3, 2022 · 6 comments
Labels
bug Something isn't working

Comments

@hanymorcos
Copy link

hanymorcos commented Aug 3, 2022

Hello,

I tried the demo. It doesn't work for me.
Unknown file extension ".astro" for /Users/hanymorcos/projects/astro/node_modules/@astro-community/astro-embed-youtube/YouTube.astro

I get this error initially.
Hint:
You likely need to add this package to vite.ssr.noExternal in your astro config file.
Stacktrace:

I added the needed changes.
The Youtube and Tweet don't render in md files. It doesn't work.

thanks,

Hany

@delucis
Copy link
Owner

delucis commented Aug 4, 2022

Thanks for the report!

Seems to be due to a change in how packages like this are handled. Tracking the bug here: withastro/astro#4071

@delucis delucis added the bug Something isn't working label Aug 4, 2022
@taoeffect
Copy link

So does this plugin not work at all now? 😢

@delucis
Copy link
Owner

delucis commented Sep 5, 2022

This issue should be fixed in the next Astro release!

Once withastro/astro#4623 is merged, astro-embed will be handled correctly.

@taoeffect
Copy link

Hi @delucis, the 'astro-embed/integration' method still doesn't work, however I was able to use a different method, via a remark plugin, to get things working as described here in case it's helpful to anyone else:

withastro/astro#4071 (comment)

@delucis
Copy link
Owner

delucis commented Sep 6, 2022

Thanks again for the bug report @hanymorcos — this should be fixed in astro 1.1.6, which just went out.

@taoeffect That integration was designed for a previous version of Astro that supported components inside .md files. That support was dropped in Astro v1 unfortunately so we may need to look at an alternative route. Happy to see a new issue to discuss what we should do and if an integration still makes sense.

@delucis delucis closed this as completed Sep 6, 2022
@taoeffect
Copy link

@delucis Done! #17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants