Still incompatible with SpongeForge in some cases

[Tommsy64]

Setup

• Farseek-1.12-2.4
• Mekanism-1.12.2-9.8.3.390
• SpongeForge-1.12.2-2838-7.1.8-RC3962
• Forge 14.23.5.2847 or 14.23.5.2838

Crash

Critical injection failure: Redirector redirect$forgeImpl$IgnoreLoadEvent$bam000(Lnet/minecraftforge/fml/common/eventhandler/EventBus;Lnet/minecraftforge/fml/common/eventhandler/Event;)Z in mixins.forge.core.json:world.chunk.ChunkMixin_Forge failed injection check, (0/1) succeeded. Using refmap mixins.forge.refmap.json

---

java.lang.NoClassDefFoundError: net/minecraft/world/chunk/Chunk

Logs

Transformer debug logs generated by adding "-Dlegacy.debugClassLoading=true" "-Dlegacy.debugClassLoadingFiner=true" "-Dlegacy.debugClassLoadingSave=true" to the JVM args.

With Mekanism

• Transformer Debug Log (Crash)
  • Relevant excerpt starts on line 300742
  • Complete log download (~70MB unzipped)
• Regular Log (Crash)

Without Mekanism

• Tranformer Debug Log (No Crash)
  • Relevant Excerpt starts on line 279460
  • Complete log download (~82MB unzipped)
• Regular Log (No Crash)

Notes

• Removing either Farseek or Mekanism causes this crash to stop happening.
• This same crash happens with some combination of Farseek plus other mods
  • I discovered this crash when adding Farseek to a modpack contain >250 mods. Even when Mekanism and all its dependents are removed from the pack, the same crash happens.

Thus, this is not an incompatibility specifically with Mekanism. In this instance, editing the MANIFEST.MF directly within the Mekanism jar to remove the coremod lines

FMLCorePluginContainsFMLMod: true
FMLCorePlugin: mekanism.coremod.MekanismCoremod

causes the crash to stop happening. Furthermore, the Mekanism coremod is very minimal and does nothing with net.minecraft.world.chunk.Chunk.

It seems that somehow Sponge is reordering the transformers again so that its mixin transformers happen after Farseek's despite the reordering in moveAfterSponge(), but only when certain other mods are present.

[Xplodin]

Getting this crash too

[nickkeane]

Modpack: Enigmatica 2 Normal
MC Forge: 2847
SpongeForge: 1.12.2-2838-7.1.9

Getting this crash as well. Mekanism fix doesn't seem to have worked.

Edit: Disabling Farseek, Streams, and Repose mods seems to have fixed the issue. Must be an issue w/ Farseek, Farseek-based mods, or Sponge itself.

[delvr]

Farseek 2.5 should fix this, could you please give it a try? Thanks.

[nickkeane]

Looks like it's working for me.

[Harleyoc1]

https://pastebin.com/6T2ZeVS9

Still getting a crash with Farseek world generation and Sponge. Originally got this crash on another server but updating Sponge to latest build worked - however this time it hasn't. Here are the version details: (BiomesOP and Immersive Engineering also mentioned in the stack trace - not sure if they have anything to do with this although seems a little odd). Update: Removing Sponge seems to still give the same error, so perhaps it's unrelated? Could anyone still look into this please?

Forge 1.12.2-14.23.5.2854
SpongeForge 1.12.2-2838-7.2.2-RC4024
Farseek 2.5
Streams 0.4.8