Hash on chain in the Timlock #82
Open
+72
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4775851501
💛 - Coveralls |
aleph-v
reviewed
Apr 26, 2023
There was a problem hiding this comment.
I don't see any real problems with this approach, there's only a minor cost increase which is not a serious consideration, so if it helps visibility that's useful.
However I'd prefer to not merge until we have a strategy on how we want to do alpha changes, our rollout timelines on new releases and security process for them. In particular I'd like to avoid a drift where this codebase's main branch has feature discrepancies with the deployed codebase(s), especially if the intent is to build front end and council kit features assuming those features exist.
|
Closing for now since this is stale. We can open another PR if we want this feature later. |
|
Re-opening for increased visibility and consideration. |
Pull Request Test Coverage Report for Build 8742545879Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would make it possible to see what actions have been registered.
It would also make it possible to see what actions are being proposed in
CoreVoting. When the actions are hashed off chain, we can only see acallHashfor Timelock proposals.#83