Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETQ instructeur je peux filtrer les dossiers par avis #9076

Merged

Conversation

colinux
Copy link
Member

@colinux colinux commented May 22, 2023

L'UX du filtre était implémentée (sur la colonne id), mais pas le back donc ça plantait. Je la remplace par la colonne answer

https://demarches-simplifiees.sentry.io/issues/4132081117/

Il restera à faire un filtre sur la colonne question_answer mais c'est un booléen et ça a d'autres implications

@colinux colinux added the bug label May 22, 2023
@what-the-diff
Copy link

what-the-diff bot commented May 22, 2023

PR Summary

  • Improved error tracking for procedures
    Added Sentry tags to procedures for better monitoring and issue identification.
  • Updated ProcedurePresentation model
    Changed the column name from "id" to "answer" in the ProcedurePresentation model and updated the corresponding French locale file.
  • Adjusted test specification
    Updated the test specification to reflect the new field name (answer) in the Avis table.

@colinux colinux force-pushed the fix-instructeurs-filter-avis branch from 2a5c7ca to b1435e1 Compare May 23, 2023 07:40
@tchak tchak added this pull request to the merge queue May 24, 2023
Merged via the queue into demarches-simplifiees:main with commit cf13b94 May 24, 2023
15 checks passed
@colinux colinux deleted the fix-instructeurs-filter-avis branch October 2, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants