Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悶 Parse errors regarding VST plugins #72

Closed
1 task done
ashduino101 opened this issue Oct 5, 2022 · 1 comment
Closed
1 task done

馃悶 Parse errors regarding VST plugins #72

ashduino101 opened this issue Oct 5, 2022 · 1 comment
Assignees
Labels
bug Something isn't working plugin-3rdparty VST 2/3, Waves, AU plugins and Fruity Wrapper
Milestone

Comments

@ashduino101
Copy link

ashduino101 commented Oct 5, 2022

Describe the issue

About 16% of the files I tested v2.0 with raised some sort of error, though loadable through normal FL Studio. Most of these failed because of "KeyError: None" on line 243 of plugin.py, seemingly due to VST plugins.

PyFLP version

2.0.0a0

What code caused this issue?

def __bytes__(self) -> bytes:
        self._stream.seek(0)
        for event in self._events:
            try:
                key = getattr(_VSTPluginEventID(event.id), "key")
            except ValueError:
                key = event.id
       -------> event.value = self._props[key]
            self._stream.write(bytes(event))
        return super().__bytes__()

Screenshots, Additional info

Had to upload as a ZIP since GitHub doesn't support FLP files as attachments by default.

Projects causing VST plugin parse errors.zip

Code of Conduct

  • I agree to follow this project's Code of Conduct
@ashduino101 ashduino101 added the bug Something isn't working label Oct 5, 2022
@demberto
Copy link
Owner

demberto commented Oct 5, 2022

I have released 2 versions after that. Can you reproduce the same issue in 2.0.0a2?

This is a problem even in 2.0.0a2. Need to check 馃憖

@demberto demberto added question Further information is requested and removed question Further information is requested labels Oct 5, 2022
@demberto demberto added this to the PyFLP 2.0.0 milestone Oct 5, 2022
@demberto demberto added the plugin-3rdparty VST 2/3, Waves, AU plugins and Fruity Wrapper label Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working plugin-3rdparty VST 2/3, Waves, AU plugins and Fruity Wrapper
Projects
None yet
Development

No branches or pull requests

2 participants