Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💡 Slicing for ModelBase collections #31

Closed
demberto opened this issue Sep 16, 2022 · 0 comments
Closed

💡 Slicing for ModelBase collections #31

demberto opened this issue Sep 16, 2022 · 0 comments
Assignees
@demberto
Labels
enhancement New feature or request models High-level API
Milestone
2.0.0

Comments

@demberto
Copy link
Owner

TIL, slicing needs to be separately implemented even when the __getitem__ method currently supports SupportsIndex values.

In layman terms, this works:

obj[0], obj[1]  # ✔

but this doesn't:

obj[0:1]    # ❌
@demberto demberto self-assigned this Sep 16, 2022
@demberto demberto added the enhancement New feature or request label Sep 16, 2022
@demberto demberto added this to the PyFLP 2.0.0 milestone Sep 16, 2022
@demberto demberto changed the title feat: slicing for ModelBase collections 💡 slicing for ModelBase collections Sep 17, 2022
@demberto demberto changed the title 💡 slicing for ModelBase collections 💡 Slicing for ModelBase collections Sep 29, 2022
@demberto demberto added the models High-level API label Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@demberto demberto

Labels
enhancement New feature or request models High-level API
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
1 participant
@demberto