Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 Iterating over the slots of an Insert results in an infinite loop #53

Closed
ttaschke opened this issue Sep 19, 2022 · 4 comments
Closed
Assignees
Labels
bug Something isn't working mixer-insert Insert a.k.a mixer channels
Milestone

Comments

@ttaschke
Copy link
Contributor

I am not 100% sure yet, if this is just a problem with how I am using PyFLP, but it seems like iterating over slots in an insert results in an infinite loop.

for slot in project.mixer[1]:
    ...

Iterating over inserts works fine on the other hand.

Related code memo:
https://github.com/demberto/PyFLP/blob/master/pyflp/mixer.py#L438-L457

@demberto demberto changed the title Bug: Iterating over the slots of an insert results in an infinite loop 🐞 Iterating over the slots of an Insert results in an infinite loop Sep 19, 2022
@demberto
Copy link
Owner

demberto commented Sep 19, 2022

Hmm, need to check. Its way more messed up.

@demberto demberto added this to the PyFLP 2.0.0 milestone Sep 19, 2022
@demberto demberto self-assigned this Sep 19, 2022
@demberto demberto added the bug Something isn't working label Sep 19, 2022
@demberto
Copy link
Owner

@ttaschke Try now, I fixed it. Although docstrings don't work for some reason for plugin parameters, You can use properties as they were intended to be.

@ttaschke
Copy link
Contributor Author

@demberto
Awesome, thanks!
Works fine now.

>>> project.mixer[0][0]
Unnamed slot (Fruity Fast Dist)

>>> for slot in project.mixer[1]:
...     type(slot)
...
<class 'pyflp.mixer.Slot'>
<class 'pyflp.mixer.Slot'>
<class 'pyflp.mixer.Slot'>
<class 'pyflp.mixer.Slot'>
<class 'pyflp.mixer.Slot'>
<class 'pyflp.mixer.Slot'>
<class 'pyflp.mixer.Slot'>
<class 'pyflp.mixer.Slot'>
<class 'pyflp.mixer.Slot'>
<class 'pyflp.mixer.Slot'>
<class 'pyflp.mixer.Slot'>

@demberto
Copy link
Owner

Nice catch, this one. And now a mention to #6

@demberto demberto added the mixer-insert Insert a.k.a mixer channels label Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working mixer-insert Insert a.k.a mixer channels
Projects
None yet
Development

No branches or pull requests

2 participants