Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider using the Type[] generic when creating type aliases #226

Closed
dansteren opened this issue Jan 12, 2023 · 1 comment
Closed

Consider using the Type[] generic when creating type aliases #226

dansteren opened this issue Jan 12, 2023 · 1 comment
Assignees
@bdemann

Comments

@dansteren
Copy link
Contributor

Chat GPT recommended creating aliases with Value = Type[str] instead of Value = str. We should see if that's really better.

Types
@bdemann bdemann self-assigned this Mar 4, 2023
@bdemann bdemann mentioned this issue Mar 4, 2023
Closed
@dansteren dansteren mentioned this issue Mar 13, 2023
Closed
@dansteren
Copy link
Contributor Author

We decided to create our own alias type so that we could ensure the enclosed type was actually a candid type (implemented in #261). So, this is no longer necessary. Closing for now.

@dansteren dansteren closed this as not planned Won't fix, can't repro, duplicate, stale Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bdemann bdemann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dansteren @bdemann