Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] UDP Push Pop Test for C API #133

Merged
merged 3 commits into from
Jul 1, 2022
Merged

[test] UDP Push Pop Test for C API #133

merged 3 commits into from
Jul 1, 2022

Conversation

ppenna
Copy link
Contributor

@ppenna ppenna commented Jun 9, 2022

Description

This PR is a partial fix for issue #131.

Summary Changes

  • Fixed signature of demi_init() to be compliant with POSIX.
  • Introduced udp-push-pop test for C API.

Further Considerations

  • The newly introduced test udp-push-pop has not yet been integrated with our regression system.

@ppenna ppenna added the enhancement Enhancement Request on an Existing Feature label Jun 9, 2022
@ppenna ppenna requested a review from BrianZill June 9, 2022 15:07
@ppenna ppenna self-assigned this Jun 9, 2022
BrianZill
BrianZill reviewed Jun 9, 2022
View reviewed changes
src/catcollar/mod.rs Outdated Show resolved Hide resolved
BrianZill
BrianZill reviewed Jun 9, 2022
View reviewed changes
src/catcollar/mod.rs Outdated Show resolved Hide resolved
@ppenna ppenna changed the base branch from unstable to dev June 9, 2022 16:48
@ppenna ppenna requested a review from BrianZill June 9, 2022 16:49
BrianZill
BrianZill reviewed Jun 9, 2022
View reviewed changes
src/catcollar/mod.rs Outdated Show resolved Hide resolved
src/catcollar/mod.rs Outdated Show resolved Hide resolved
src/catcollar/mod.rs Show resolved Hide resolved
tests/c/udp-push-pop.c Outdated Show resolved Hide resolved
tests/c/udp-push-pop.c Outdated Show resolved Hide resolved
tests/c/udp-push-pop.c Outdated Show resolved Hide resolved
tests/c/udp-push-pop.c Outdated Show resolved Hide resolved
tests/c/udp-push-pop.c Show resolved Hide resolved
tests/c/udp-push-pop.c Show resolved Hide resolved
tests/c/udp-push-pop.c Show resolved Hide resolved
@ppenna ppenna requested a review from BrianZill June 13, 2022 18:28
@ppenna ppenna force-pushed the dev branch 7 times, most recently from b0529e2 to 8bae292 Compare June 27, 2022 13:05
BrianZill
BrianZill approved these changes Jun 30, 2022
View reviewed changes
Copy link
Contributor

@BrianZill BrianZill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. Would like to switch to c99 style comments (a.k.a. C++ style comments) at some point though.

@ppenna ppenna merged commit c437102 into dev Jul 1, 2022
@ppenna ppenna deleted the enhancement-tests-c branch July 1, 2022 13:27
@ppenna ppenna mentioned this pull request Jul 7, 2022
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrianZill BrianZill BrianZill approved these changes

Assignees

@ppenna ppenna

Labels
enhancement Enhancement Request on an Existing Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ppenna @BrianZill