[catnap] Set Source Address in OperationResult for pop()
#149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrianZill
reviewed
Jul 28, 2022
| Some(sin) => { | ||
| let ip: Ipv4Addr = Ipv4Addr::from(sin.ip()); | ||
| let port: u16 = sin.port(); | ||
| Some(SocketAddrV4::new(ip, port)) |
There was a problem hiding this comment.
Don't you need to perform network-to-host byte-order conversion here? nix::sys::socket::recvfrom looks to just be returning the sockaddr in a byte array, which would presumably yield big-endian values. Unless something funky is happening in "as_sockaddr_in" (which I can't seem to find documentation for, where is that coming from?).
There was a problem hiding this comment.
@BrianZill, we don't need to because as_sockaddr_in().ip() and as_sockaddr_in().port() return the IP address and port number in host endianness, respectively. See: https://docs.rs/nix/latest/nix/sys/socket/struct.SockaddrIn.html
ppenna
force-pushed
the
bugfix-catnap-pop
branch
from
afdeb32
to
5ea5942
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #147.
Sumary of Changes
PopFuture::poll()to userecvfrom()and return the source address of the messageOperation::get_result()to set the address inOperationResultaccordinglyAdditional Information
recvfrom()is required becausenixdoes not provide a conversion function betweenSockaddrStorageandSocketAddrV4(https://docs.rs/nix/latest/nix/sys/socket/union.SockaddrStorage.html). Once we drop the use ofnixin favor oflibcwe should get rid of this.OperationResultforpop()Is Set toNone#148 for more details.