[runtime] Bad Deref in DemiBuffer::drop() Causes Segmentation Fault
#312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrianZill
changed the title
DemiBuffer::drop() causes segmentation faultDemiBuffer::drop() Causes Segmentation Fault
BrianZill
force-pushed
the
bugfix-demibuffer
branch
from
352257f
to
9794e4c
Compare
ppenna
changed the title
DemiBuffer::drop() Causes Segmentation FaultDemiBuffer::drop() Causes Segmentation Fault
anandbonde
reviewed
Oct 26, 2022
ppenna
approved these changes
Oct 26, 2022
BrianZill
force-pushed
the
bugfix-demibuffer
branch
from
ee12b4a
to
0fe05b3
Compare
BrianZill
force-pushed
the
bugfix-demibuffer
branch
from
0fe05b3
to
e894c85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes Issue#310.
The drop code was referencing
DemiBuffer'sptrfield directly, rather than calling the internalget_ptr()method to get theMetaDatapointer.One take-away from this experience, is that we can't trust individual unit tests to (indirectly) test
dropmethods. The DemiBuffer unit tests ran fine when run individually, or even together. It appears to be non-deterministic as to whether Cargo's test harness keeps the test environment around long enough for destructors to run.