Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[winport] Enhancement: Add CatnapW for Windows #314

Merged
merged 1 commit into from
Oct 29, 2022
Merged

[winport] Enhancement: Add CatnapW for Windows #314

merged 1 commit into from
Oct 29, 2022

Conversation

anandbonde
Copy link
Contributor

@anandbonde anandbonde commented Oct 26, 2022 •
edited

This is one of the PRs that addresses the issue #274.

Here are previous PRs for reference that created way for this change:

@anandbonde anandbonde marked this pull request as draft October 26, 2022 23:43
@anandbonde anandbonde force-pushed the enhancement-catnapw branch 4 times, most recently from ced60b4 to cbb6ad0 Compare October 27, 2022 22:29
@anandbonde anandbonde marked this pull request as ready for review October 27, 2022 22:50
BrianZill
BrianZill reviewed Oct 28, 2022
View reviewed changes
Cargo.toml Show resolved Hide resolved
ppenna
ppenna approved these changes Oct 28, 2022
View reviewed changes
Copy link
Contributor

@ppenna ppenna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I have left some suggestions for the existing code.

Also, it would be nice to review the README.md file to include instructions that would enable one to build CatnapW

examples/c/common.h Outdated Show resolved Hide resolved
src/rust/catnapw/futures/accept.rs Outdated Show resolved Hide resolved
src/rust/catnapw/futures/connect.rs Outdated Show resolved Hide resolved
src/rust/catnapw/futures/pop.rs Outdated Show resolved Hide resolved
src/rust/catnapw/futures/pop.rs Outdated Show resolved Hide resolved
src/rust/catnapw/futures/push.rs Outdated Show resolved Hide resolved
src/rust/catnapw/futures/pushto.rs Outdated Show resolved Hide resolved
tests/c/syscalls.c Show resolved Hide resolved
BrianZill
BrianZill approved these changes Oct 28, 2022
View reviewed changes
Copy link
Contributor

@BrianZill BrianZill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@anandbonde anandbonde merged commit c0e51d5 into dev Oct 29, 2022
@anandbonde anandbonde deleted the enhancement-catnapw branch October 29, 2022 03:37
@anandbonde anandbonde mentioned this pull request Dec 2, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppenna ppenna ppenna approved these changes

@BrianZill BrianZill BrianZill approved these changes

@iyzhang iyzhang Awaiting requested review from iyzhang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anandbonde @ppenna @BrianZill