[catnip] Missing Check for Return Value of rte_eal_init()
#327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrianZill
reviewed
Nov 13, 2022
src/rust/catnip/runtime/mod.rs
Outdated
| rte_eal_init(eal_init_refs.len() as i32, eal_init_refs.as_ptr() as *mut _); | ||
| let ret: libc::c_int = unsafe { rte_eal_init(eal_init_refs.len() as i32, eal_init_refs.as_ptr() as *mut _) }; | ||
| if ret < 0 { | ||
| bail!("EAL initialization failed {:?}", ret); |
There was a problem hiding this comment.
Is there any way we can get access to rte_errno here? And print that instead of the return value? rte_eal_init() is documented as returning -1 on error, and "rte_errno is set to a value indicating the cause for failure".
There was a problem hiding this comment.
Thanks for noting this. I've updated the fix for getting and printing the value of rte_errno.
ppenna
force-pushed
the
bugfix-catnip-init
branch
from
023a9d9
to
3116630
Compare
BrianZill
approved these changes
Nov 16, 2022
ppenna
force-pushed
the
bugfix-catnip-init
branch
from
d8d56a6
to
911692e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #326.
Summary of Changes
rte_eal_init()