Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[inetstack] Push Empty Buffer on FIN #370

Merged
merged 1 commit into from
Dec 15, 2022
Merged

Conversation

ppenna
Copy link
Contributor

@ppenna ppenna commented Dec 13, 2022

Description

This is a workaround for #369.

Summary of Changes

  • Added code for push a zero-length buffer when a FIN has been received and the concerned TCP connection is closing.

@ppenna ppenna added the bug Something Isn't Working label Dec 13, 2022
@ppenna ppenna self-assigned this Dec 13, 2022
Copy link
Contributor

@BrianZill BrianZill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we discussed offline, this is good as a quick workaround for Issue #369. The real fix needs to wait for Issue #367 to also be fixed.

This is a workaround for issue
#369.

Currently, our TCP stack misses to inform the socket layer that a
connetion is closing (ie. a FIN has arrived).

This commit works around this issue and pushes a zero-length buffer
when a FIN has been received and the connection is in a closing state.
@ppenna ppenna merged commit 35b118d into dev Dec 15, 2022
@ppenna ppenna deleted the workaround-inetstack-close branch December 15, 2022 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something Isn't Working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants