Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Bumping DPDK Version #375

Merged
merged 3 commits into from
Dec 15, 2022
Merged

[build] Bumping DPDK Version #375

merged 3 commits into from
Dec 15, 2022

Conversation

ppenna
Copy link
Contributor

@ppenna ppenna commented Dec 15, 2022

Description

This PR fixes #256

Summary of Changes

  • Updated scripts/setup/dpdk.sh to support DPDK 22.11
  • Updated dpdk-rs and fixed concerned changes

@ppenna ppenna added the enhancement Enhancement Request on an Existing Feature label Dec 15, 2022
@ppenna ppenna self-assigned this Dec 15, 2022
@ppenna ppenna changed the title [contrib] Bumping DPDK Version [build] Bumping DPDK Version Dec 15, 2022
Copy link
Contributor

@anandbonde anandbonde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@@ -254,31 +253,28 @@ impl DPDKRuntime {

println!("dev_info: {:?}", dev_info);
let mut port_conf: rte_eth_conf = unsafe { MaybeUninit::zeroed().assume_init() };
port_conf.rxmode.max_rx_pkt_len = if use_jumbo_frames {
port_conf.rxmode.max_lro_pkt_size = if use_jumbo_frames {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we using a different field now? Or has it just been renamed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They changed some variables and constants.

@ppenna ppenna merged commit 2f42857 into dev Dec 15, 2022
@ppenna ppenna deleted the enhancement-update-dpdk branch December 15, 2022 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement Request on an Existing Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[build] Bump DPDK Version
2 participants