Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[build] Fixing Build Warnings #393

Merged
merged 6 commits into from
Jan 6, 2023
Merged

[build] Fixing Build Warnings #393

merged 6 commits into from
Jan 6, 2023

Conversation

ppenna
Copy link
Contributor

@ppenna ppenna commented Jan 3, 2023

Summary of Changes

  • Fixed some bug warnings
  • Drop some unrequired allow() statements

@ppenna ppenna added the enhancement Enhancement Request on an Existing Feature label Jan 3, 2023
@ppenna ppenna self-assigned this Jan 3, 2023
BrianZill
BrianZill approved these changes Jan 6, 2023
View reviewed changes
Copy link
Contributor

@BrianZill BrianZill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for cleaning this up!

@ppenna ppenna merged commit 352d40d into dev Jan 6, 2023
@ppenna ppenna deleted the enhancement-build-warnings branch January 6, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrianZill BrianZill BrianZill approved these changes

@anandbonde anandbonde Awaiting requested review from anandbonde

@iyzhang iyzhang Awaiting requested review from iyzhang

Assignees

@ppenna ppenna

Labels
enhancement Enhancement Request on an Existing Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ppenna @BrianZill